Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[benchmark] Remove dependency for H100 benchmark step #11572

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

khluu
Copy link
Collaborator

@khluu khluu commented Dec 27, 2024

The step still couldn't run since it depends on block-h100 which was removed earlier.

@khluu khluu requested a review from simon-mo December 27, 2024 20:25
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added the ci/build label Dec 27, 2024
@simon-mo simon-mo merged commit ccb1aab into main Dec 30, 2024
24 of 25 checks passed
@simon-mo simon-mo deleted the khluu/fix_h100_bench branch December 30, 2024 20:27
xcnick pushed a commit to xcnick/vllm that referenced this pull request Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants